Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Circular Buffer Exercise #624

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Add Circular Buffer Exercise #624

merged 5 commits into from
Feb 22, 2024

Conversation

tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Feb 21, 2024 •
edited
Loading

We didn't agree on it, but I found a little time to implement this exercise too.
Hope that's OK?

I have linked in on the forum too.

https://forum.exercism.org/t/implement-some-missing-php-exercises-for-48in24/9865

neenjaw
neenjaw approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving optimistically, but I think it would be an improvement to remove the exception from the read method.

exercises/practice/circular-buffer/.meta/example.php Show resolved Hide resolved
@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 21, 2024
@tomasnorre tomasnorre force-pushed the add-circular-buffer-exercise branch from c45e659 to 39e402c Compare February 21, 2024 19:45
mk-mxp
mk-mxp requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I love your flow 😄

exercises/practice/circular-buffer/.meta/example.php Show resolved Hide resolved
exercises/practice/circular-buffer/CircularBufferTest.php Outdated Show resolved Hide resolved
@tomasnorre tomasnorre force-pushed the add-circular-buffer-exercise branch from 39e402c to fd281e3 Compare February 22, 2024 08:03
@tomasnorre tomasnorre force-pushed the add-circular-buffer-exercise branch from fd281e3 to bc9f553 Compare February 22, 2024 09:28
mk-mxp
mk-mxp approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work! Thanks a lot for contributing.

@mk-mxp mk-mxp merged commit 1144087 into exercism:main Feb 22, 2024
12 checks passed
@mk-mxp mk-mxp mentioned this pull request Feb 22, 2024
Open
28 tasks
@tomasnorre tomasnorre deleted the add-circular-buffer-exercise branch February 28, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neenjaw neenjaw neenjaw approved these changes

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@tomasnorre tomasnorre

Labels
x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasnorre @neenjaw @mk-mxp