Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing function names to match the instructions #621

Merged
merged 3 commits into from
Feb 21, 2024
Merged

changing function names to match the instructions #621

merged 3 commits into from
Feb 21, 2024

Conversation

kuprelweronika
Copy link
Contributor

the previous functions name was wrong, in instructions will be shorter version

@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 20, 2024

Hello and welcome, Weronika!

When we change the function names as you suggest, all the previous solutions to the exercise are invalid. So we must keep the names in that file.

You could adjust the .docs/instructions.md to match the PHP stub. In the code example the name matches the PHP file, only in the explaining text it differs. Do you want to do that?

@kuprelweronika
Copy link
Contributor Author

Yes, I will try to do that :)

@mk-mxp mk-mxp self-requested a review February 20, 2024 22:51
@mk-mxp mk-mxp added x:knowledge/none No existing Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Feb 20, 2024
@kuprelweronika
Copy link
Contributor Author

I came back this names in php code and change names in .docs/instructions.md

mk-mxp
mk-mxp approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great. Thanks for contributing!

@mk-mxp mk-mxp merged commit 7ff9c2c into exercism:main Feb 21, 2024
12 checks passed
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request Feb 21, 2024
@kuprelweronika @tomasnorre
Match instructions to students stub in annalyns-infiltration (exercis…
458dc24 
…m#621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@kuprelweronika kuprelweronika

Labels
x:knowledge/none No existing Exercism knowledge required x:module/concept-exercise Work on Concept Exercises x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuprelweronika @mk-mxp