Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to "High School Sweethearts" and GitHub actions #575

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Nov 5, 2023

Hi all,

thanks a lot for this great tool and learning experience. I'm happy to provide something back.

  • Fixed typo in the name of "High School Sweethearts"
  • Added a missing test for whitespace removal in the first task
  • As I had GitHub actions with warnings, I fixed the PHP version setting of the unit testing action

I hope these break nothing out of the scope of this repo.

@@ -38,7 +38,7 @@
{
"uuid": "d6b00994-36b1-4d2c-9a7f-d55f3cbdf4de",
"slug": "sweethearts",
"name": "Highschool Sweetheats",
"name": "Highschool Sweethearts",
Copy link
Member

@kotp kotp Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Does not appear to be available in "problem-specifications" upstream, but I wonder if other exercise tracks have this same issue.

@neenjaw neenjaw added x:module/concept Work on Concepts x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Nov 6, 2023
@neenjaw neenjaw merged commit c7fef69 into exercism:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/concept Work on Concepts x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants