Put all rules into PHPCS config

- Add XML namespace for completeness
- Remove non-existent `type="int"`
- Add directory rules for improved test coverage and required
  exceptions
- Fix the new upcoming violations

composer.json

@@ -15,7 +15,7 @@
     "squizlabs/php_codesniffer": "^3.6"
   },
   "scripts": {
-    "lint:check": "./vendor/bin/phpcs --ignore=*/hello-world/*,*/concept/* --standard=phpcs-php.xml ./exercises",
-    "lint:fix": "./vendor/bin/phpcbf --standard=phpcs-php.xml ./exercises"
+    "lint:check": "phpcs --standard=phpcs-php.xml",
+    "lint:fix": "phpcbf --standard=phpcs-php.xml"
   }
 }

exercises/concept/annalyns-infiltration/.meta/exemplar.php

@@ -34,4 +34,3 @@ public function canLiberate(
         );
     }
 }
-

exercises/concept/city-office/.meta/exemplar/Form.php

@@ -2,23 +2,23 @@
 
 class Form
 {
-    function blanks(int $length): string
+    public function blanks(int $length): string
     {
         return str_repeat(" ", $length);
     }
 
-    function letters(string $word): array
+    public function letters(string $word): array
     {
         return mb_str_split($word);
     }
 
-    function checkLength(string $word, int $max_length): bool
+    public function checkLength(string $word, int $max_length): bool
     {
         $difference = mb_strlen($word) - $max_length;
         return $difference <= 0;
     }
 
-    function formatAddress(Address $address): string
+    public function formatAddress(Address $address): string
     {
         $formatted_street = mb_strtoupper($address->street);
         $formatted_postal_code = mb_strtoupper($address->postal_code);

exercises/concept/city-office/Form.php

@@ -2,23 +2,23 @@
 
 class Form
 {
-    function blanks($length)
+    public function blanks($length)
     {
         return str_repeat(" ", $length);
     }
 
-    function letters($word)
+    public function letters($word)
     {
         return mb_str_split($word);
     }
 
-    function checkLength($word, $max_length)
+    public function checkLength($word, $max_length)
     {
         $difference = mb_strlen($word) - $max_length;
         return $difference <= 0;
     }
 
-    function formatAddress($address)
+    public function formatAddress($address)
     {
         $formatted_street = mb_strtoupper($address->street);
         $formatted_postal_code = mb_strtoupper($address->postal_code);

exercises/concept/city-office/ReflectionAssertions.php

@@ -45,7 +45,8 @@ private function assertMethodParameter(
         if (is_null($parameter)) {
             $this->fail(
                 "Method '$parameter_name' missing parameter $parameter_index"
-                . " named '$parameter_name'");
+                . " named '$parameter_name'"
+            );
         }
 
         if ($parameter->getName() !== $parameter_name) {

exercises/concept/lasagna/Lasagna.php

@@ -1,5 +1,27 @@
 <?php
 
+/*
+ * By adding type hints and enabling strict type checking, code can become
+ * easier to read, self-documenting and reduce the number of potential bugs.
+ * By default, type declarations are non-strict, which means they will attempt
+ * to change the original type to match the type specified by the
+ * type-declaration.
+ *
+ * In other words, if you pass a string to a function requiring a float,
+ * it will attempt to convert the string value to a float.
+ *
+ * To enable strict mode, a single declare directive must be placed at the top
+ * of the file.
+ * This means that the strictness of typing is configured on a per-file basis.
+ * This directive not only affects the type declarations of parameters, but also
+ * a function's return type.
+ *
+ * For more info review the Concept on strict type checking in the PHP track
+ * <link>.
+ *
+ * To disable strict typing, comment out the directive below.
+ */
+
 declare(strict_types=1);
 
 class Lasagna

exercises/concept/lucky-numbers/.meta/exemplar.php

@@ -17,11 +17,13 @@ public function isPalindrome(int $number): bool
 
     public function validate(string $input): string
     {
-        if ($input === '')
+        if ($input === '') {
             return 'Required field';
+        }
 
-        if ((int) $input <= 0)
+        if ((int) $input <= 0) {
             return 'Must be a whole number larger than 0';
+        }
 
         return '';
     }

exercises/concept/sweethearts/.meta/exemplar.php

@@ -46,4 +46,3 @@ public function pair(
             HEART;
     }
 }
-

exercises/concept/windowing-system/.meta/exemplar.php

@@ -7,21 +7,21 @@ class ProgramWindow
     public $height;
     public $width;
 
-    function __construct()
+    public function __construct()
     {
         $this->y = 0;
         $this->x = 0;
         $this->height = 600;
         $this->width = 800;
     }
 
-    function move(Position $position)
+    public function move(Position $position)
     {
         $this->y = $position->y;
         $this->x = $position->x;
     }
 
-    function resize(Size $size)
+    public function resize(Size $size)
     {
         $this->height = $size->height;
         $this->width = $size->width;
@@ -33,7 +33,7 @@ class Position
     public $y;
     public $x;
 
-    function __construct($y, $x)
+    public function __construct($y, $x)
     {
         $this->y = $y;
         $this->x = $x;
@@ -45,7 +45,7 @@ class Size
     public $height;
     public $width;
 
-    function __construct($height, $width)
+    public function __construct($height, $width)
     {
         $this->height = $height;
         $this->width = $width;

phpcs-php.xml

@@ -1,6 +1,13 @@
 <?xml version="1.0"?>
-<ruleset name="xPHP">
-  <description>Coding standard for xPHP</description>
+<ruleset
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:noNamespaceSchemaLocation="vendor/squizlabs/php_codesniffer/phpcs.xsd"
+  name="Exercism PHP Coding Standard"
+>
+  <description>Coding standard for Exercism PHP exercises</description>
+
+  <file>exercises</file>
+  <file>src</file>
 
   <!-- Include all sniffs in the PSR12 standard except... -->
   <rule ref="PSR12">
@@ -9,10 +16,17 @@
     <exclude name="PSR1.Files.SideEffects.FoundWithSymbols" />
   </rule>
   <rule ref="vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/DeclareStrictTypesSniff.php">
+    <exclude-pattern>*/exemplar\.php</exclude-pattern>
+    <exclude-pattern>*/concept/*</exclude-pattern>
+    <exclude-pattern>*/hello-world/*</exclude-pattern>
     <properties>
-      <property name="newlinesCountBetweenOpenTagAndDeclare" type="int" value="1" />
-      <property name="spacesCountAroundEqualsSign" type="int" value="0" />
+      <property name="newlinesCountBetweenOpenTagAndDeclare" value="1" />
+      <property name="spacesCountAroundEqualsSign" value="0" />
     </properties>
   </rule>
-  <rule ref="src/Sniffs/ExplainStrictTypesSniff.php"/>
+  <rule ref="src/Sniffs/ExplainStrictTypesSniff.php">
+    <exclude-pattern>*/*Test\.php</exclude-pattern>
+    <exclude-pattern>*/exemplar\.php</exclude-pattern>
+    <exclude-pattern>src/*</exclude-pattern>
+  </rule>
 </ruleset>