Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run.exw #3

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Update run.exw #3

merged 2 commits into from
Jan 18, 2025

Conversation

petelomax
Copy link
Contributor

@petelomax petelomax commented Aug 2, 2024

make status fail not error, except when no results.json got created

changes may look a bit messier than they really are due to an extra indent level, unless side-by-side + ignore whitespace

make status fail not error
@petelomax petelomax requested a review from a team as a code owner August 2, 2024 13:57
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change error to fail?

@petelomax
Copy link
Contributor Author

petelomax commented Aug 3, 2024

An attempt to avoid the blanket "AN ERROR OCCURRED" message when running online, ie "An error occurred while running your tests. This might mean that there was an issue in our infrastructure, or it might mean that you have something in your code that's causing our systems to break.\n\nPlease check your code, and if nothing seems to be wrong, try running the tests again.", and instead display some details of what the error(/failure) actually is - which, oddly enough, syntax errors already deliver properly.

Reverts a probably wrong modification I made to empty-file/expected_results.json but also (likely wrongly) changes syntax-error/expected_results.json, which actually seems fine, the latter was to make (/force) the CI tests pass. One of line 63/68 may want putting back, but I'd struggle to even guess which. All I know with any level of confidence is there is something subtly wrong with at least one of the results.json files I'm creating. It might instead be that the assert on line 91 (and/or 96) just needs removing.

Summary (before these changes):
pass: fine
syntax error: fine (erm, sometimes)
wrong results: not fine

When I say sometimes for syntax error, what I mean is that in my clock example I have

local function normalise(integer m)
...
global function create_clock(integer hours, minutes)
return normalise(hours*60+minutes)

If I make it normaliseX I get an undefined msg as expected, but create_clockX gets me the blanket error msg.

@ErikSchierboom
Copy link
Member

An attempt to avoid the blanket "AN ERROR OCCURRED" message when running online,

That likely indicates some other problem, because I just check and something like this results.json outputs fine:

{
  "version": 1,
  "status": "error",
  "message": "test-words.8th\nsyntax-error.8th\nException: Unknown q2437@#:: at line 1 byte 81 in syntax-error.8th <- G:eval <- I:include?: task REPL"
}

@petelomax petelomax merged commit feed6d8 into main Jan 18, 2025
1 check passed
@petelomax
Copy link
Contributor Author

Didn't help...

@petelomax petelomax deleted the errfail branch January 19, 2025 13:07
@petelomax petelomax restored the errfail branch January 19, 2025 13:07
@petelomax petelomax deleted the errfail branch January 19, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants