largest-series-product: Do not test slices #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,22 +6,15 @@ use Test::Exception; | |||
|
|
|||
| my $module = $ENV{EXERCISM} ? 'Example' : 'Series'; | |||
|
|
|||
| plan tests => 13; | |||
| plan tests => 14; | |||
There was a problem hiding this comment.
this is me noticing that I forgot to update that in #106 , so I had to make up for it.
The slices functions is an internal implementation details and thus the test case for the largest-series-product problem should not be concerned with testing it. Its presence may cause students to falsely think that their solution has to use this function, instead of the alternative implementation of only iterating through the digits once. The slices tests are already well-covered by the series exercise already existing in this track. If it is desired to give hints on how to approach this problem (which was one advantage of having the slices test), then consider including a hints file and/or directory in the largest-series-product directory. This PR arises from discussion in exercism/problem-specifications#192
petertseng
changed the title
kytrinyx
added a commit
that referenced
this pull request
Mar 22, 2016
largest-series-product: Do not test slices
|
Thanks @petertseng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slices functions is an internal implementation details and thus the
test case for the largest-series-product problem should not be concerned
with testing it.
Its presence may cause students to falsely think that their solution has
to use this function, instead of the alternative implementation of only
iterating through the digits once.
The slices tests are already well-covered by the series exercise already
existing in this track.
If it is desired to give hints on how to approach this problem (which
was one advantage of having the slices test), then consider including a
hints file and/or directory in the largest-series-product directory.
This PR arises from discussion in
exercism/problem-specifications#192