Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-running of workflows #158

Merged

Conversation

ErikSchierboom
Copy link
Member

  • Don't open a new issue if it already exists
  • Prevent pull request from being created more than once

Copy link
Member Author

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I haven't yet tested the workflow, but I wanted to get feedback first

run: |
cp -a main/global-files/. track-repo/

- name: Determine if repo is a tooling repo
if: steps.pr-already-exists.outputs.result == 'false'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not added this check to the steps that check for the repo being a tooling or track repo, as steps.is-tooling-repo.outputs.result == 'true' will be false anyway due to the step where that result is used. The same goes for the last steps that all check for steps.changes.outputs.changes == 'true', which will always be false due to the step to set that to true not being executed if the PR already exists

Copy link
Contributor

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to test this somewhere but it looks good to me. Limiting the listForRepo results with the right label and state should save us some API calls because we're probably not going to run into pagination.

Copy link
Contributor

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those checks look good.

@ErikSchierboom ErikSchierboom temporarily deployed to abort-timer March 8, 2022 15:02 Inactive
@ErikSchierboom ErikSchierboom temporarily deployed to abort-timer March 8, 2022 15:09 Inactive
@SaschaMann
Copy link
Contributor

Needs a rebase

@ErikSchierboom ErikSchierboom force-pushed the allow-rerunning-of-workflows branch from 749b3c8 to 2d48cf4 Compare March 10, 2022 12:35
@ErikSchierboom
Copy link
Member Author

Rebased

@ErikSchierboom ErikSchierboom merged commit 54b950e into exercism:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants