-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow re-running of workflows #158
Allow re-running of workflows #158
Conversation
ErikSchierboom
commented
Mar 4, 2022
- Don't open a new issue if it already exists
- Prevent pull request from being created more than once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I haven't yet tested the workflow, but I wanted to get feedback first
run: | | ||
cp -a main/global-files/. track-repo/ | ||
|
||
- name: Determine if repo is a tooling repo | ||
if: steps.pr-already-exists.outputs.result == 'false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not added this check to the steps that check for the repo being a tooling or track repo, as steps.is-tooling-repo.outputs.result == 'true'
will be false anyway due to the step where that result is used. The same goes for the last steps that all check for steps.changes.outputs.changes == 'true'
, which will always be false due to the step to set that to true not being executed if the PR already exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be best to test this somewhere but it looks good to me. Limiting the listForRepo
results with the right label and state should save us some API calls because we're probably not going to run into pagination.
@SaschaMann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those checks look good.
Needs a rebase |
749b3c8
to
2d48cf4
Compare
Rebased |