Updated GHA for LLVM 18 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completed the hello-world and leap exercises. Updated configuration.
Completed the difference-of-squares practice exercise, and added the `bin/format-all.sh` script that recursively searches for .odin files and runs `odinfmt` on them.
All source files have been reformatted with the `odinfmt.json` spec. `bin/format-all.sh` is now run automatically on commit.
The `test.yml` GitHub workflow now pushes any changes that it makes, so that they persist in the repo.
`test.yml` now only attempts a commit and push if the automated formatting actually changed any files.
The verify-exercises script now runs the individual test for both concept and practice exercises, and is the default in the GitHub workflow.
Tests were lifted from the Gleam track.
- The README now contains more thorough instructions on how to add a new exercise. - Fixed a variable name in the test runner that caused the "test all solutions" loop to run multiple times when verifying solutions.
- Fixed bin/run-test.sh so that it doesn't delete the stub solution when a test fails. - Restored exercises, and added a NotImplemented error condition for the stubs.
- Ran the code formatter on source files. - Rehaul of the README to follow Python's example.
The workflow now uses a fixed commit hash to pull a specific release of Odin. We now use Ubuntu 22.04 which has the libffi8 dependency, and add clang as the only other dependency.
Added a check to bin/run-test.sh so that verifies that the stub solution does *not* pass any tests. Fixed hello-world.odin to actually be a stub.
- Improved bin/run-test.sh to add more visible color coding to the output. - Replaced NotImplemented error codes with a compile-time panic for procedures that have not yet been implemented. - Fixed stubs that were actually complete examples.
- Exercises' unit tests were modified so that only a minimal subset of tests are initially enabled; the rest are skipped. - The test runner was modified to automatically unskip all test cases before running the tests.
Tooling and CI set up + 1st four exercises (exercism#25)
ErikSchierboom
approved these changes
Sep 3, 2024
|
@Nezteb Happy to merge? This is just a fix to the CI pipeline, which was still pulling the latest release, causing dependency failures. It's now locked to both the hash of |
gvrooyen
added a commit
to gvrooyen/odin
that referenced
this pull request
Sep 3, 2024
Updated GHA for LLVM 18 (exercism#31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the latest Odin release requires LLVM 18, which made the current GHA test runner fail, despite the "Setup Odin" task being pinned to a specific commit hash.
This PR ensures that LLVM 18 is built before installing Odin.
Minor formatting changes to some other source files.