Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(sum-of-multiples): sync docs #514

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kytrinyx
Copy link
Member

The sum-of-multiples exercise has been overhauled as part of a project to make practice exercises more consistent and friendly.

For more context, please see the discussion in the forum, as well as the pull request that updated the exercise in the problem-specifications repository:


If you approve this pull request, I will eventually merge it. However, if you are happy with this change please merge the pull request, as it will get the changes into the hands of the students much more quickly.

If this pull request contradicts the exercise on your track, please add a review with request changes. This will block the pull request from getting merged.

Otherwise, as discussed in the forum post linked to above, we aim to take an optimistic merging approach.

If you wish to suggest tweaks to these changes, please open a pull request to the exercism/problem-specifications repository to discuss, so that everyone who has an interest in the shared exercise descriptions can participate.

The sum-of-multiples exercise has been overhauled as part of a project
to make practice exercises more consistent and friendly.

For more context, please see the discussion in the forum, as well as
the pull request that updated the exercise in the problem-specifications
repository:

- https://forum.exercism.org/t/new-project-making-practice-exercises-more-consistent-and-human-across-exercism/3943
- exercism/problem-specifications#2249
@ee7 ee7 changed the title Sync sum-of-multiples docs with problem-specifications exercises(sum-of-multiples): sync docs Apr 10, 2023
@ee7 ee7 self-requested a review April 10, 2023 12:22
@ee7 ee7 self-assigned this Apr 10, 2023
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like and appreciate many of the changes to other exercises, but for my taste, I think this particular one makes the exercise significantly less clear. Coming up with stories is hard, and I think it's just especially difficult for this exericse.

I'll set this as draft (assuming that this blocks automatic merging) and wait a little while on this one, in case anyone suggests further changes in prob-specs.

Edit: further changes in prob-specs:

@ee7 ee7 marked this pull request as draft April 10, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants