Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE: change date in copyright notice #304

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

exercism-bot
Copy link
Contributor

@ee7 ee7 marked this pull request as draft June 2, 2021 09:03
@ee7
Copy link
Member

ee7 commented Jun 2, 2021

The exercism/org-wide-files thing looks useful.

But I'll set this as draft for now, because this might technically be a bad change. This might be best as (see #198)

Copyright (c) 2014-2019 Exercism, Inc
Copyright (c) 2019-2021 Exercism

or maybe

Copyright (c) 2014 Exercism, Inc
Copyright (c) 2019 Exercism

These seem questionable/bad:

Copyright (c) 2014 Exercism, Inc
Copyright (c) 2014-2021 Exercism

There's an argument that we should only use a date range if every year in that range was a "copyrightable year". It turns out that's okay for this repo, but it's hard to do that generally.

Copyright notices doesn't mean what most people think they mean. See e.g.:

@ee7 ee7 changed the title 🤖 Sync org-wide files to upstream repo LICENSE: change date in copyright notice Jun 2, 2021
@ee7
Copy link
Member

ee7 commented Aug 30, 2021

I'll merge this to keep the other org-wide-files commits more atomic. But to be pedantic, this change might violate

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

I think it'd be better if the LICENSE file was just kept in CODEOWNERS, rather than in org-wide-files.

@ee7 ee7 marked this pull request as ready for review August 30, 2021 08:54
@ee7 ee7 merged commit 0f5b76a into exercism:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants