Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grains: use $v1 instead of $10 as output register for the high word #196

Merged

Conversation

danilopiazza
Copy link
Contributor

The grains exercise instructions suggest using the $10 register to store the high word of the output, but the test runner expects it in $v1.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 12, 2023
@keiravillekode
Copy link
Contributor

lgtm

@danilopiazza
Copy link
Contributor Author

lgtm

Thanks! Should I post the link to this PR on the relevant forum topic?

@keiravillekode
Copy link
Contributor

Yes.

@danilopiazza
Copy link
Contributor Author

Yes.

Done, thank you! https://forum.exercism.org/t/grains-exercise-typo/8173

@keiravillekode
Copy link
Contributor

resolves #198

@keiravillekode keiravillekode reopened this Jan 9, 2024
@keiravillekode keiravillekode merged commit e4e96c7 into exercism:main Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants