Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Scores - Simplify constructor #427

Merged
merged 1 commit into from
Dec 4, 2023
Merged

High Scores - Simplify constructor #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/practice/high-scores/.meta/example.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ end

return function(values)
return {
values = table.unpack(values),
values = values,
scores = scores,
latest = latest,
personal_best = personal_best,
Expand Down
24 changes: 12 additions & 12 deletions exercises/practice/high-scores/high-scores_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,87 +3,87 @@ local HighScores = require 'high-scores'
describe('high-scores', function()
it('table of scores', function()
local values = { 30, 50, 20, 70 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 30, 50, 20, 70 }
assert.are.same(expected, scores:scores())
end)

it('latest score', function()
local values = { 100, 0, 90, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = 30
assert.equal(expected, scores:latest())
end)

it('personal best', function()
local values = { 40, 100, 70 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = 100
assert.equal(expected, scores:personal_best())
end)

it('personal top three from a list of scores', function()
local values = { 10, 30, 90, 30, 100, 20, 10, 0, 30, 40, 40, 70, 70 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 100, 90, 70 }
assert.are.same(expected, scores:personal_top_three())
end)

it('personal top highest to lowest', function()
local values = { 20, 10, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 30, 20, 10 }
assert.are.same(expected, scores:personal_top_three())
end)

it('personal top when there is a tie', function()
local values = { 40, 20, 40, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 40, 40, 30 }
assert.are.same(expected, scores:personal_top_three())
end)

it('personal top when there are less than 3', function()
local values = { 30, 70 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 70, 30 }
assert.are.same(expected, scores:personal_top_three())
end)

it('personal top when there is only one', function()
local values = { 40 }
local scores = HighScores { values }
local scores = HighScores(values)
local expected = { 40 }
assert.are.same(expected, scores:personal_top_three())
end)

it('latest score after personal top scores', function()
local values = { 70, 50, 20, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local _ = scores:personal_top_three()
local expected = 30
assert.equal(expected, scores:latest())
end)

it('scores after personal top scores', function()
local values = { 30, 50, 20, 70 }
local scores = HighScores { values }
local scores = HighScores(values)
local _ = scores:personal_top_three()
local expected = { 30, 50, 20, 70 }
assert.are.same(expected, scores:scores())
end)

it('latest score after personal best', function()
local values = { 20, 70, 15, 25, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local _ = scores:personal_best()
local expected = 30
assert.equal(expected, scores:latest())
end)

it('scores after personal best', function()
local values = { 20, 70, 15, 25, 30 }
local scores = HighScores { values }
local scores = HighScores(values)
local _ = scores:personal_best()
local expected = { 20, 70, 15, 25, 30 }
assert.are.same(expected, scores:scores())
Expand Down
Loading