Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Luhn with problem specifications #199

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented Feb 22, 2024

Syncs the Luhn exercise with the problem specification and fixes #197

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 22, 2024
@kahgoh
Copy link
Member Author

kahgoh commented Feb 22, 2024

@ErikSchierboom ready for review

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If you want to do another pr, it looks like the word count tests are also failing in ci.

@ErikSchierboom ErikSchierboom merged commit 70c2852 into exercism:main Feb 22, 2024
3 of 5 checks passed
@kahgoh kahgoh deleted the fix/luhn branch September 18, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

luhn-number: provide CI example
2 participants