Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Acronym practice exercise #187

Closed
wants to merge 1 commit into from
Closed

Add Acronym practice exercise #187

wants to merge 1 commit into from

Conversation

kephas
Copy link
Contributor

@kephas kephas commented Feb 5, 2024

It's missing for #48in24 week 7.

Copy link

github-actions bot commented Feb 5, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 5, 2024
@kahgoh
Copy link
Member

kahgoh commented Feb 6, 2024

I noticed the commit is missing a number of changes:

  • the track's config.json is missing the change to add the exercise
  • the exercise is missing the .meta directory and its example.lfe, config.json and tests.toml
  • the exercise is also missing .docs directory and its instructions.md file (and possible introduction.md if it exists)

These files can be obtained using configlet's sync command.

@kephas
Copy link
Contributor Author

kephas commented Feb 7, 2024

I pushed a new version according to the reviews.

@ErikSchierboom
Copy link
Member

@kephas I can't re-open this PR. Could you recreate the PR and ping me once you've done that?

@BNAndras BNAndras added the x:module/practice-exercise Work on Practice Exercises label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants