upgrade grade-school exercise implementation to the spec of 1.0.0 version
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eparovyshnaya
commented
Dec 7, 2019
eparovyshnaya
commented
- Discrepancies between description and canonical data are discussed in #1623 issue for problem-specification
- As a result:
- test set and reference implementation are reworked to strictly correspond to the canonical data
- stub implementation is revised accordingly
…f 1.0.0 version 1. Discrepancies between *description* and *canonical data* are discussed in [#1623 issue for problem-specification](exercism/problem-specifications#1623) 2. As a result: - test set and reference implementation are reworked to strictly correspond to the *canonical data* - stub is revised accordingly
|
After discussion, intended to rework test dsl to something empowering the following students(
"Franklin" to 5,
"Bradley" to 5,
"Jeff" to 1
)
.fromGrade(5)
.shouldBe(listOf("Bradley", "Franklin")) |
…f 1.0.0 version -- reimplement test set basing on new dsl
|
Lookning good! Nicely done with the dsl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.