Update tests for 'Saddle Points' #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The structure was inspired from the typescript version of this exercise. |
SleeplessByte
added
the
sync 🔄
|
Can't review it right now, but skimming this looks like amazing work @ovidiu141 ! Thank you so far. We'll review shortly. |
|
Unfortunately I've deleted my old fork, so now the PR appears to be made from an 'unknown repository'. If this is an issue I can easily recreate the PR from my current fork. Just let my know. |
tejasbubane
reviewed
Nov 26, 2019
| row.forEach((cell, colIndex) => { | ||
| if (cell === rowMaxs[rowIndex] && cell === colMins[colIndex]) { | ||
| saddlePoints.push([rowIndex, colIndex]); | ||
| export class SaddlePoints { |
There was a problem hiding this comment.
Good that you removed Matrix class & old tests. Here I would suggest using a plain function instead of static method inside class. In #274 we decided to use classes only if some local state is required.
|
@ovidiu141 Can you also add version number in |
|
Closing in favor of #785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also update structure of skeleton file. Fixes: #764