Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scale-generator exercise #754

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

seeksort
Copy link
Contributor

@seeksort seeksort commented Oct 8, 2019

Adding scale-generator exercise. Closes #751.

One thing I'm not sure about is updating config.json. I just based it on the same entry in other tracks, not sure if there's other stuff I should consider.

@SleeplessByte
Copy link
Member

Sweet. We'll review this. You did great with the config.

  • Is this a new UUID?
  • We need to decide which exercise in the core unlocks this exercise
  • Are those topics correct with this exercise?

@seeksort
Copy link
Contributor Author

seeksort commented Oct 9, 2019

Yup, I used a uuidgen. And the topics are covered by the exercise; I can add more if you think there are other relevant topics!

How do we determine the unlock exercise? Is it intended to be the same for all tracks or does it depend on the track? The Python version uses kindergarden-garten as the unlock exercise, but when I tried to do that I got an error about using a non-core exercise to unlock another non-core exercise.

@SleeplessByte
Copy link
Member

Good question!

Each track has its own core. You can see it here for JavaScript, in bold. Each side exercise is unlocked by a core exercise. Since tracks are not the same across languages, neither are the unlocks. Usually I do the following:

  • Is it related to a core exercise, probably there (re: ciphers)
  • Otherwise, is there a core exercise without anything? Re-assign things so each core exercise has some (not the case now)
  • Otherwise, use binomial on the difficulty. So in this case, it should be tied to a core exercise with 2-4 difficulty, or can be added to an earlier one if there's not a lot of 3s yet.

If we look at the Python track, we can see that kindergarten is mid of the second-third of the core exercises, which I think is late. I think unlocked_by: pangram is a good candidate!

@seeksort
Copy link
Contributor Author

Thanks for the guidance @SleeplessByte ! Looking at pangram, I agree it's a good candidate for unlocking this one, since it looks like there are similar matching and arrays elements. I'll push up an update for config.json.

@seeksort seeksort force-pushed the exercise-scale-generator branch from f234176 to f30d75c Compare October 10, 2019 02:09
@SleeplessByte
Copy link
Member

Let's do this!

@SleeplessByte SleeplessByte merged commit 576d560 into exercism:master Oct 10, 2019
@SleeplessByte
Copy link
Member

@seeksort if you have 5 more minutes, would you be so kind and see if you can help us out by responding to this issue?

Awesome work on this. Let's see how this propagates :)

@SleeplessByte
Copy link
Member

image

Woot! 🎉

@seeksort
Copy link
Contributor Author

Yay! And it deployed so quickly!

Sure, I'll check it out. Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new exercise: scale-generator
3 participants