Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exercise tests to be TDD orientated. #697

Closed
wants to merge 1 commit into from
Closed

Change exercise tests to be TDD orientated. #697

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2019

I have rearranged the tests for this exercise to be more test driven development orientated as we would potentially want the easier test cases to come first so the user doing the exercise can write code to fail fast (eg. negative coins, 0 coins, etc) then build up to the difficult scenarios of using Lilliputian and Lower Elbonia Coins.

This is just a suggestion as I found the exercises as a great way of doing TDD - albeit the tests having already been wrote!

@ghost ghost changed the title Change tests to be TDD orientated. Change exercise tests to be TDD orientated. Jul 9, 2019
@SleeplessByte SleeplessByte added the sync 🔄 Sync an exercise with the latest version of the problem-spec label Jul 9, 2019
@SleeplessByte
Copy link
Member

Thanks! Would you also be willing on making this change on the problem-spec repository?

https://github.com/exercism/problem-specifications/

I want to stay close to the canonical when we can, and it seems that this change might benefit a lot of tracks.

@ghost
Copy link
Author

ghost commented Jul 31, 2019

Sure, I've submitted the following PR that reflects the updated ordering: exercism/problem-specifications#1563

@SleeplessByte
Copy link
Member

Since we're now using test.toml and are free to arrange/re-arrange the tests to our order, I'm going to close this in favour of a potential future new PR that just re-orders the tests in our repo only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync 🔄 Sync an exercise with the latest version of the problem-spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant