[Translation service] Constrain service api #2539
Conversation
The "work" got executed immediately, and just the response was delayed with setTimeout. The user could make a next fetch without waiting for a response. Now the work itself is done in the timeout callback, getting delayed too.
Any Error child class satisfied tests that expected `toThrow(Error)`, meaning unintended behaviour still passed the tests.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| setTimeout( | ||
| () => callback(this.values[text][0] ? undefined : makeRandomError()), | ||
| () => { | ||
| this.values[text].shift(); |
|
/format |
|
The "Format code" action has started running. |
|
The "Format code" action has finished running. |
|
For security reasons,
|
Will open a forum thread in a minute.
[Edit] Forum post