Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

largest-series-product: Do not test digits/slices #203

Merged
merged 1 commit into from
Mar 14, 2016
Merged

largest-series-product: Do not test digits/slices #203

merged 1 commit into from
Mar 14, 2016

Conversation

petertseng
Copy link
Member

The digits and slices functions are internal implementation details and
thus the test case for the largest-series-product problem should not be
concerned with testing them. The series tests could potentially be moved
to the series exercise (already implemented by this track).

Their presence may cause students to falsely think that their solution
has to use these two functions, instead of the alternative
implementation of only iterating through the digits once.

If it is desired to give hints on how to approach this problem (which
was one advantage of having the digits and slices tests), then consider
including a hints file and/or directory in the largest-series-product
directory.

This PR arises from discussion in
exercism/problem-specifications#192

Relevant to #202: This will satisfy the first part of the issue (ensure
the track does not test implementation details); the question of whether
hints are necessary is uncertain (as it is not known whether students
will consider this problem too hard without guidance).

The digits and slices functions are internal implementation details and
thus the test case for the largest-series-product problem should not be
concerned with testing them. The series tests could potentially be moved
to the series exercise (already implemented by this track).

Their presence may cause students to falsely think that their solution
has to use these two functions, instead of the alternative
implementation of only iterating through the digits once.

If it is desired to give hints on how to approach this problem (which
was one advantage of having the digits and slices tests), then consider
including a hints file and/or directory in the largest-series-product
directory.

This PR arises from discussion in
exercism/problem-specifications#192

Relevant to #202: This will satisfy the first part of the issue (ensure
the track does not test implementation details); the question of whether
hints are necessary is uncertain (as it is not known whether students
will consider this problem too hard without guidance).
@matthewmorgan
Copy link
Contributor

@petertseng Thanks!

matthewmorgan added a commit that referenced this pull request Mar 14, 2016
largest-series-product: Do not test digits/slices
@matthewmorgan matthewmorgan merged commit 86f425d into exercism:master Mar 14, 2016
@petertseng petertseng deleted the lsp branch March 14, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants