-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V3] Add Concept Exercise: While and Switch #1073
[V3] Add Concept Exercise: While and Switch #1073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. As with all the while/loop/switch exercises in other languages, this one suffers that if you know recursion / if you know difficult / complex map reduces, it will be easier to solve that way, but I really like how you've made it likely enough that someone will solve this the intended way.
Analyzers will do their job here. We can have analyzers (as per your design document) shout if a while etc. is not used, so I think we can cover our cases there!
Co-authored-by: Derk-Jan Karrenbeld <[email protected]> Co-authored-by: Tejas Bubane <[email protected]>
Thanks for the reviews! One open question: #1073 (comment), all the other things are fixed. I also fixed all the code comments that were real sentences to be written as such (first letter capitalized, period at the end). |
Sweeet. Very nice. I've also answered the final open question. |
From my point of view this is now ready to be merged. |
Addresses #991
Notes
CI is failing because of a configlet update but the errors are not related to the new exercise.Resolved