Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep is failing on Windows #878

Closed
SleeplessByte opened this issue Oct 17, 2020 · 0 comments
Closed

grep is failing on Windows #878

SleeplessByte opened this issue Oct 17, 2020 · 0 comments
Labels
bug 🐛 Something isn't working good first issue

Comments

@SleeplessByte
Copy link
Member

Introduced via #737, implemented in #750

The issue is newlines. They are LF or CRLF depending on the OS/git settings in the data files, but LF in the test strings.

Attempted partial fix in #875
@SleeplessByte SleeplessByte added bug 🐛 Something isn't working good first issue labels Oct 17, 2020
SleeplessByte added a commit that referenced this issue Dec 16, 2020
@SleeplessByte
Update grep to work cross-env
494f023 
Fixes #878

- Normalise paths
- Add helper functions to stub so the student doesn't need to figure this out
- Add track insert hint into the README that clarifies how `grep` can be called using node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SleeplessByte