Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Connect Exercise #2027

Merged
merged 15 commits into from
Oct 7, 2021

Conversation

kkyb123
Copy link
Contributor

@kkyb123 kkyb123 commented Sep 24, 2021

pull request

Closes #1743
Provide test, starter and reference implementations for the connect practice exercise


Reviewer Resources:

Track Policies

@kkyb123 kkyb123 changed the title #1743 Implement Connect Exercise Implement Connect Exercise Sep 24, 2021
Copy link
Contributor

@jmrunkle jmrunkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

exercises/practice/connect/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/practice/connect/src/main/java/Connect.java Outdated Show resolved Hide resolved
exercises/practice/connect/src/test/java/ConnectTest.java Outdated Show resolved Hide resolved
exercises/practice/connect/src/test/java/ConnectTest.java Outdated Show resolved Hide resolved
exercises/practice/connect/src/main/java/Connect.java Outdated Show resolved Hide resolved
@kkyb123
Copy link
Contributor Author

kkyb123 commented Sep 25, 2021

Thanks for the fedback @jmrunkle !

kkyb123 and others added 5 commits September 25, 2021 16:47
Use splitting on sentence break to reduce the splash radius as suggested.

Co-authored-by: Jason Runkle <[email protected]>
Add trailing newline as suggested

Co-authored-by: Jason Runkle <[email protected]>
…efine the UnionFind data structure in a class. We define a board and its methods. We then use them in providing a solution to the exercise.
@kkyb123 kkyb123 requested a review from jmrunkle October 6, 2021 05:50
@kkyb123
Copy link
Contributor Author

kkyb123 commented Oct 6, 2021

@jmrunkle sorry for the delay. I did the necessary refactoring. Please could you have a look?

exercises/practice/connect/src/test/java/ConnectTest.java Outdated Show resolved Hide resolved
exercises/practice/connect/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/practice/connect/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/practice/connect/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/practice/connect/src/main/java/Connect.java Outdated Show resolved Hide resolved
@kkyb123
Copy link
Contributor Author

kkyb123 commented Oct 6, 2021

@jmrunkle please could you have a look again?

@kkyb123 kkyb123 requested a review from jmrunkle October 6, 2021 18:05
Copy link
Contributor

@jmrunkle jmrunkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments then I can merge it, thanks for working on this!

exercises/practice/connect/.meta/config.json Outdated Show resolved Hide resolved
@jmrunkle jmrunkle added the x:size/large Large amount of work label Oct 7, 2021
@jmrunkle jmrunkle merged commit c464543 into exercism:main Oct 7, 2021
@kkyb123
Copy link
Contributor Author

kkyb123 commented Oct 7, 2021

Just a couple minor comments then I can merge it, thanks for working on this!

I was about to apply the changes but thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connect: implement exercise
2 participants