Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atbash-cipher: make test failures easier to troubleshoot #161

Closed
1 of 2 tasks
jtigger opened this issue Oct 30, 2016 · 1 comment
Closed
1 of 2 tasks

atbash-cipher: make test failures easier to troubleshoot #161

jtigger opened this issue Oct 30, 2016 · 1 comment
Labels
code good first issue Good for newcomers

Comments

@jtigger
Copy link
Contributor

jtigger commented Oct 30, 2016 •
edited
Loading

atbash-cipher uses the JUnit Parameterized test runner. This was done to make the test more compact (and once you learn how the mechanism works, easier to read).

However, when a test fails, the error message does not indicate which value failed. This makes it really difficult to know why the test failed.

Test failures should clearly indicate what failed.

To Do:

  • ensure that this exercise is using JUnit 4.12 or later
  • add a format string to the @Parameters annotation.

(ref: #147)
@jtigger jtigger added code good first issue Good for newcomers labels Oct 30, 2016
FridaTveit added a commit to FridaTveit/java that referenced this issue Dec 21, 2016
@FridaTveit
Issue exercism#160, exercism#161, exercism#162, exercism#163, exercis…
7cea536 
…m#164, exercism#165 and exercism#166: Added format string to @parameters annotation in AtbashTest, BinaryTest, OctalTest, RaindropsTest and RomanNumeralsTest. Removed repeated word in format string for PiglatinTest and ScrabbleScoreTest.
@FridaTveit FridaTveit mentioned this issue Dec 21, 2016
Merged
@jtigger
Copy link
Contributor Author

jtigger commented Dec 27, 2016

OOOPS! We missed the second @Parameters on DecodeTest... re-opening just for that.

@jtigger jtigger reopened this Dec 27, 2016
@FridaTveit FridaTveit mentioned this issue Jan 3, 2017
Merged
@jtigger jtigger closed this as completed in 62962a4 Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtigger