Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armstrong-numbers: Bump test to version 1.1.0.3 #856

Merged
merged 2 commits into from
Oct 5, 2019

Conversation

karen-pal
Copy link
Contributor

@karen-pal karen-pal commented Oct 5, 2019

Upgraded test to v1.1.0

exercism/problem-specifications#1505

@karen-pal karen-pal force-pushed the sync-test-armstrong-numbers-1.1.0 branch from c3c250e to 0aa7402 Compare October 5, 2019 15:26
Copy link
Contributor

@sshine sshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you.

exercises/armstrong-numbers/package.yaml Outdated Show resolved Hide resolved
@sshine sshine changed the title armstrong-numbers: Bump test to version 1.1.0.0 armstrong-numbers: Bump test to version 1.1.0.3 Oct 5, 2019
@sshine sshine merged commit 799da03 into exercism:master Oct 5, 2019
@sshine
Copy link
Contributor

sshine commented Oct 5, 2019

Whoops, that should have been a squash commit and not a rebase commit.

@petertseng
Copy link
Member

Whenever possible, please make the commit messages include a summary of the relevant test changes. In this case it would have been very easy to say "Test that zero is an Armstrong number", which means that someone who just wants to know the summary can see it from the commit message, whereas someone who wants the full detail can still visit the provided link to exercism/problem-specifications#1505.

This was referenced Oct 5, 2019
@sshine
Copy link
Contributor

sshine commented Oct 5, 2019

Good point, thank you for making it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants