Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acronym: Add "ROTFLSHTMDCOALM" test case from shared metadata. #715

Merged
merged 2 commits into from
Sep 10, 2018
Merged

acronym: Add "ROTFLSHTMDCOALM" test case from shared metadata. #715

merged 2 commits into from
Sep 10, 2018

Conversation

sshine
Copy link
Contributor

@sshine sshine commented Sep 10, 2018

No description provided.

@petertseng petertseng changed the title Add "ROTFLSHTMDCOALM" test case from shared metadata. acronym: Add "ROTFLSHTMDCOALM" test case from shared metadata. Sep 10, 2018
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, great.

A few things I'm going to do:

these seem all trivial enough that I'd like to get this moving so we can continue with the substantive work rather than the bookkeeping

@petertseng
Copy link
Member

petertseng commented Sep 10, 2018

Do not panic that I accidentally changed nucleotide-count's version instead of acronym; I have rectified my mistake

@sshine
Copy link
Contributor Author

sshine commented Sep 10, 2018

Excellent, thanks for letting me know of all the things I missed in a friendly manner. :-)

@petertseng
Copy link
Member

I hope I haven't done so in too unfriendly of a manner previously (for example, if I was too terse and therefore seemed snippy)! If I have, I apologise.

@petertseng petertseng merged commit ca34355 into exercism:master Sep 10, 2018
@petertseng
Copy link
Member

(It was equally likely that it referred to me as a maintainer of any other open source project, so I preferred to overapologise for something I didn't do rather than fail to apologise for something I did)

Thanks for this work!

@sshine
Copy link
Contributor Author

sshine commented Sep 10, 2018

No, you weren't unfriendly at any point. I'd just expect to be yelled at for not having read the documentation in various places that explain version bumping in this and that file. :)

@sshine sshine deleted the ROTFLSHTMDCOALM branch September 10, 2018 14:21
@petertseng
Copy link
Member

Oh no, it wouldn't have been fair to yell, because the kicker is that it's pretty undocumented. The only saving grace is that at least it's documented-as-undocumented in #538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants