-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acronym: Add "ROTFLSHTMDCOALM" test case from shared metadata. #715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, great.
A few things I'm going to do:
- prefix the commit message and PR title with exercise affected, so it's easy to tell at a glance from https://github.com/exercism/haskell/pulls and/or
git log
without extra flags - since this follows problem-specifications version 1.4.0, change first three version components of https://github.com/exercism/haskell/blob/master/exercises/acronym/package.yaml#L2 to 1.4.0
- since tests changed, increase last version component in https://github.com/exercism/haskell/blob/master/exercises/acronym/package.yaml#L2 by 1.
these seem all trivial enough that I'd like to get this moving so we can continue with the substantive work rather than the bookkeeping
Do not panic that I accidentally changed |
Excellent, thanks for letting me know of all the things I missed in a friendly manner. :-) |
I hope I haven't done so in too unfriendly of a manner previously (for example, if I was too terse and therefore seemed snippy)! If I have, I apologise. |
(It was equally likely that it referred to me as a maintainer of any other open source project, so I preferred to overapologise for something I didn't do rather than fail to apologise for something I did) Thanks for this work! |
No, you weren't unfriendly at any point. I'd just expect to be yelled at for not having read the documentation in various places that explain version bumping in this and that file. :) |
Oh no, it wouldn't have been fair to yell, because the kicker is that it's pretty undocumented. The only saving grace is that at least it's documented-as-undocumented in #538. |
No description provided.