kindergarten-garden 1.0.0.2: edit descriptions and elide middle students #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptions are clearer as to the significance of the garden size, or the fact that the given student list is non-alphabetical. The tests of the middle children in the full garden are elided. The canonical data file was added in exercism/problem-specifications#770
petertseng
commented
May 8, 2017
| @@ -47,18 +47,10 @@ specs = describe "kindergarten-garden" $ do | |||
|
|
|||
| plants "Alice" `shouldBe` [ Violets , Radishes, Violets , Radishes ] | |||
| plants "Bob" `shouldBe` [ Clover , Grass , Clover , Clover ] | |||
| plants "Charlie" `shouldBe` [ Violets , Violets , Clover , Grass ] | |||
There was a problem hiding this comment.
we could keep these since we already have them, and just declare that they're Haskell specific. don't really care (but note that this is the only place that many of these names are tested!)
There was a problem hiding this comment.
I don't care too much about the track-specific cases. If they are important, we should include them in x-common, otherwise, I think we should remove them.
rbasso
approved these changes
May 8, 2017
| @@ -47,18 +47,10 @@ specs = describe "kindergarten-garden" $ do | |||
|
|
|||
| plants "Alice" `shouldBe` [ Violets , Radishes, Violets , Radishes ] | |||
| plants "Bob" `shouldBe` [ Clover , Grass , Clover , Clover ] | |||
| plants "Charlie" `shouldBe` [ Violets , Violets , Clover , Grass ] | |||
There was a problem hiding this comment.
I don't care too much about the track-specific cases. If they are important, we should include them in x-common, otherwise, I think we should remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions are clearer as to the significance of the garden size, or
the fact that the given student list is non-alphabetical.
The tests of the middle children in the full garden are elided.
The canonical data file was added in exercism/problem-specifications#770