common: Add stack.yaml to common files folder and link pov as a test.
#443
Conversation
Create a folder to hold files that are common to all exercises. - Add `common` folder to ignore section of `config.json`. - Add `stack.yaml` to the new folder.
When copying files before testing, `cp` copies the symbolic links instead of the target files. This adds `-L` so that relative symbolic links will not break building the tests in Travis-CI.
|
By the way, I take it you requested for reviews to become required? I'm only guessing, since I don't think either of us would have been able to change it ourselves. No problem, just want to know when it changed |
Sorry! I was asking Katrina to add abo64 and took the opportunity to ask if it would be a good idea to enable protection for the master branch against accidentals pushes/merges. She just enabled that, so I didn't had the time to send you a message. We can ask her to revert that if you prefer. |
These are OK! Only "Require branches to be up to date before merging" has historically slowed us down. Conversation being continued in #444 |
|
Interesting approach using the symlink. Hopefully, this will be a suitable solution. You put the shared file in a |
|
My hope is that the symbolic link will magically turn in a file with the contents from the target file in the If we had the functionality describe in this comment we would be able to avoid the symbolic links completely. I'm just using the same name I used in the example there. |
|
Okay, please let me know if it works, I'm really curious :) |
|
I believe it will work, since I believe both of these do follow symlinks:
And I am hoping the test agrees with this. I may want to add a test to trackler that ensures that this continues to work, if we start to depend on the functionality.
Will local development work without the stack.yaml present as well? For me it asks me to |
What OS / shell are you using @petertseng? |
Starting from the repo root: Well, sure I could I could try to have a Okay, guess not. By the way it acts as expected if I leave stack.yaml as-is (the symlink). |
|
We can see whether this change is live: exercism/DEPRECATED.trackler@0f08803#diff-c6c56fb57dc791175a5882b2f7b448d7 As you can see, the change to symlink The latest changes are live (Sublist and Bob have 2016-11-29 markers) http://x.exercism.io/v2/exercises/haskell/pov doesn't have stack.yaml, which is surprising.\ It's something to do with the way the gem is packaged. I do |
|
The current situation is that Considering that our experience with symbolic links failed, show we revert this PR or do we have any expectation that this will be fixed in a short time? |
|
Since the current obstacle is that RubyGems needs to release a fixed version (the current one 2.6.8 apparently has the incorrect behaviour), it's not certain this can be fixed in a short time. Alternatively we could ask @kytrinyx to use a different version of RubyGems to package the trackler gem, one >= 2.5.2 and <= 2.6.4, if willing, but it could be an undue burden. |
|
Considering that we still have the hope that this will be fixed, instead of reverting everything, I'm considering just restoring |
As discussed in #442, it would be nice to have a single
stack.yamlfile and link all the others to it.We expect this approach will work, but it is better to test fetching an exercise before making huge changes.
This PR does the following:
common/stack.yamlcommonto ignore section inconfig.json.travis.ymlto dereference links when copying files for testingstack.yamlfrom exercismpovRelated to #442.