Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rna-transcription: Changes return type to Maybe #168

Merged
merged 1 commit into from
Jun 30, 2016
Merged

rna-transcription: Changes return type to Maybe #168

merged 1 commit into from
Jun 30, 2016

Conversation

samjonester
Copy link
Contributor

  • Error case is now defined, eliminating the desire to throw an error
    for invalid input.
  • The test and example solution are more idiomatic to Haskell, using a
    Maybe.

Closes #166

@rbasso
Copy link
Contributor

rbasso commented Jun 30, 2016

Great! Thanks! 👍

I'm going to merge it!

Just one thing. It's always good to take a look at exercism/x-common to see if there is a .json file for the exercise. Usually those files have a good list of test cases we should implement, this way we don't have to duplicate work thinking about that.

@samjonester
Copy link
Contributor Author

Do you know why CI didn't run for this PR? Also, thanks for the link. I can amend the commit with the other test cases before you merge.

@rbasso
Copy link
Contributor

rbasso commented Jun 30, 2016 •
edited
Loading

Trying to find out what's happening with Travis. I'll hold this PR until the problem is solved.

I updated some old PRs and they are running. Seems it didn't "saw" this PR

@rbasso
Copy link
Contributor

rbasso commented Jun 30, 2016 •
edited
Loading

I wrote a new PR #169 , just to test it. Same problem!

Let's just wait. I guess this will be solved automatically.

@rbasso rbasso changed the title Changes return type of RNA transcription to Maybe rna-transcription: Changes return type to Maybe Jun 30, 2016
@rbasso rbasso closed this Jun 30, 2016
@rbasso rbasso reopened this Jun 30, 2016
@samjonester samjonester force-pushed the rna-transcription-maybe branch 2 times, most recently from 3a3ce84 to 444081b Compare June 30, 2016 15:07
@samjonester
Copy link
Contributor Author

Looks like it's working again. I've also updated the test cases.

@samjonester
Change return type of RNA transcription to Maybe
444081b 
- Error case is now defined, eliminating the desire to throw an `error`
for invalid input.
- The test and example solution are more idiomatic to Haskell, using a
  `Maybe`.

Closes exercism#166
@rbasso
Copy link
Contributor

rbasso commented Jun 30, 2016

Perfect! 😄

@rbasso rbasso merged commit 31696b2 into exercism:master Jun 30, 2016
rbasso added a commit that referenced this pull request Jul 1, 2016
@rbasso
Merge pull request #172 from rbasso/fix-rna-nucleotide-dependencies
90700c6 
rna-transcription: Fix missing dependency cause by #168.
@rbasso rbasso mentioned this pull request Jul 1, 2016
Merged
@rbasso rbasso mentioned this pull request Jul 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samjonester @rbasso