Add Affine Cipher exercise #1202
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@MatthijsBlom Mind taking a look? |
There was a problem hiding this comment.
@ErikSchierboom looks good to me. My one question is not very important.
| - use the `Text` type e.g. `decode :: Text -> Text` and refer to | ||
| `Data.Text` combinators as e.g. `T.pack`. |
There was a problem hiding this comment.
Text.pack is unnecessary when OverloadedStrings is enabled. Do we want to recommend this extension? Though it is idiomatic, it is one more complication as well.
OverloadedStrings has been mentioned once before on this track: in bob/.approaches/text/content.md.
Co-authored-by: Matthijs <[email protected]>
Co-authored-by: Matthijs <[email protected]>
|
Can we merge this PR or is still something missing? |
|
@ErikSchierboom is/was stricken by flu. I'm fine with merging. |
Added a new Haskell practice exercise Affine Cipher based on the available problem specification.