Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine cipher exercise #1196

Closed
wants to merge 3 commits into from
Closed

Conversation

tofische
Copy link
Contributor

Added a new Haskell practice exercise Affine Cipher based on the available problem specification.

Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 20, 2024
@@ -0,0 +1,22 @@
{
"authors": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Haskell maintainer here, but this should contain your GitHub username.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, corrected.

@MatthijsBlom
Copy link
Contributor

It looks like you included rational-numbers by accident.

@tofische
Copy link
Contributor Author

It looks like you included rational-numbers by accident.

As I explained here, it was my mistake because I created the affine-cipher-exercise branch from the not-yet-merged rational-numbers-exercise branch and not from the main branch.

If I understand git properly, this PR can be merged without problems after Rational Numbers is merged, so no corrective action is necessary - is this assumption correct?

@MatthijsBlom
Copy link
Contributor

I suspect so. git rebase --onto should also work, I think.

@tofische
Copy link
Contributor Author

I suspect so. git rebase --onto should also work, I think.

It shall be corrected now.

@tofische
Copy link
Contributor Author

tofische commented Feb 1, 2024

PR is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants