Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common dependencies #32

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add common dependencies #32

merged 1 commit into from
Nov 25, 2021

Conversation

ErikSchierboom
Copy link
Member

This PR pre-loads the following dependencies:

  • QuickCheck
  • lens
  • parallel
  • vector
  • split
  • random
  • string-conversions

See exercism/haskell#1006

This PR pre-loads the following dependencies:

- QuickCheck
- lens
- parallel
- vector
- split
- random
- string-conversions
Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@ErikSchierboom
Copy link
Member Author

@petertseng Does this look okay to you?

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... the list of dependencies is exactly what I suggested, so from that perspective that can't have any complaints. So now we have to think of other angles.

I'm wondering, would it be a good idea or a bad idea to add a comment explaining, for each dependency, why it's in this list? Right now I don't yet see a reason to do that. Perhaps that idea will become useful when this list of dependencies is audited later on and the maintainers of the test runner have to decide whether to keep or dump a given dependency, but since this list is just starting nobody is sure when that will happen. But let us remember that idea for later.

I have of course no way of knowing whether adding those dependencies to this list here will actually solve the problems, but that is supposedly easy to test - submit a solution to diamond before and after and see if there are differences in the result.

@ErikSchierboom ErikSchierboom merged commit a7a6fa4 into main Nov 25, 2021
@ErikSchierboom
Copy link
Member Author

I'm wondering, would it be a good idea or a bad idea to add a comment explaining, for each dependency, why it's in this list? Right now I don't yet see a reason to do that. Perhaps that idea will become useful when this list of dependencies is audited later on and the maintainers of the test runner have to decide whether to keep or dump a given dependency, but since this list is just starting nobody is sure when that will happen. But let us remember that idea for later.

I agree. In the future, it is probably best to have a separate document listing all the dependencies, as then the test runner code itself could parse any errors and remarkt that the student can only use one of the supported dependencies.

@ErikSchierboom
Copy link
Member Author

@petertseng I've just run the tests on my dnd-character solution (which uses QuickCheck), and it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants