pig-latin: add generator and update example #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
reviewed
Dec 30, 2017
exercises/pig-latin/example.go
Outdated
|
|
||
| //translate a sentence |
There was a problem hiding this comment.
please start with PigLatin for lint
ferhatelmas
reviewed
Dec 30, 2017
exercises/pig-latin/example.go
Outdated
| } | ||
| return strings.Join(sw, " ") | ||
| } | ||
|
|
||
| //translates a single word |
ferhatelmas
reviewed
Dec 30, 2017
exercises/pig-latin/example.go
Outdated
| } else if x := cons.FindStringSubmatchIndex(s); x != nil { | ||
| result = s[x[3]:] + s[:x[3]] + "ay" | ||
| } | ||
| return |
There was a problem hiding this comment.
let's refactor naked return
ferhatelmas
reviewed
Dec 30, 2017
| t.Fatalf("PigLatin(%q) = %q, want %q.", test.in, pl, test.pl) | ||
| for _, test := range testCases { | ||
| if pl := PigLatin(test.input); pl != test.expected { | ||
| t.Fatalf("FAIL: %s\nPigLatin(%q) = %q, want %q.", test.description, test.input, pl, test.expected) | ||
| } |
There was a problem hiding this comment.
Could you also add a line of description for successful case ?
ferhatelmas
reviewed
Dec 30, 2017
exercises/pig-latin/.meta/gen.go
Outdated
| } | ||
|
|
||
| // Template to generate test cases. | ||
| var tmpl = `package igpay |
There was a problem hiding this comment.
I know it was there before but what does it mean ? IMHO, better to make it piglatin and rename the functions to Sentence and Word. what do you think ?
ferhatelmas
suggested changes
Dec 30, 2017
ferhatelmas
changed the title
ferhatelmas
changed the title
ferhatelmas
reviewed
Dec 31, 2017
|
|
||
| func TestPigLatin(t *testing.T) { | ||
| for _, test := range testCases { | ||
| if pl := PigLatin(test.input); pl != test.expected { | ||
| t.Fatalf("FAIL: %s\nPigLatin(%q) = %q, want %q.", test.description, test.input, pl, test.expected) | ||
| fmt.Printf("Test: %s\n", test.description) |
There was a problem hiding this comment.
If test fails we will see it twice, let's write it after if and also we can write PASS instead of Test since we know it passed.
ferhatelmas
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of #605.