sieve: add generator #962
Merged
sieve: add generator #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .meta/gen.go to generate cases_test.go. Update test program to use generated test case array. Update example solution to pass test which includes limit as prime. For exercism#605.
ferhatelmas
reviewed
Nov 16, 2017
exercises/sieve/.meta/gen.go
Outdated
|
|
||
| // The JSON structure we expect to be able to unmarshal into | ||
| type js struct { | ||
| Cases []OneCase |
There was a problem hiding this comment.
Might inline since we're not adding methods to type, etc.
Replace OneCase with inline struct since no methods are necessary.
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .meta/gen.go to generate cases_test.go.
Update test program to use generated test case array.
Update example solution to pass test which includes limit as prime.
For #605.