Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collatz-conjecture: add generator #958

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions exercises/collatz-conjecture/.meta/gen.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
package main

import (
"log"
"text/template"

"../../../gen"
)

func main() {
t, err := template.New("").Parse(tmpl)
if err != nil {
log.Fatal(err)
}
var j js
if err := gen.Gen("collatz-conjecture", &j, t); err != nil {
log.Fatal(err)
}
}

type OneCase struct {
Description string
Number int
Expected interface{}
}

// The JSON structure we expect to be able to unmarshal into
type js struct {
Cases []OneCase
}

func (c OneCase) Valid() bool {
valid, _ := determineExpected(c.Expected)
return valid
}

func (c OneCase) Answer() int {
_, answer := determineExpected(c.Expected)
return answer
}

// determineExpected examines an .Expected interface{} object and determines
// whether a test case is valid(bool) and has an answer or expects an error.
// returning valid and answer.
func determineExpected(expected interface{}) (bool, int) {
ans, ok := expected.(float64)
if ok {
return ok, int(ans)
}
return false, 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without if, return ok, int(ans) might suffice but as you wish to keep for clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it. Thanks @ferhatelmas

}

// template applied to above data structure generates the Go test cases
var tmpl = `package collatzconjecture

{{.Header}}

var testCases = []struct {
description string
input int
expectError bool
expected int
}{
{{range .J.Cases}}{
description: "{{.Description}}",
input: {{.Number}},
{{if .Valid}} expected: {{.Answer}},
{{- else}} expectError: true,
{{- end}}
},
{{end}}}
`
43 changes: 43 additions & 0 deletions exercises/collatz-conjecture/cases_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package collatzconjecture

// Source: exercism/problem-specifications
// Commit: 25c4479 Collatz-conjecture: remove trailing space in test name (#839)
// Problem Specifications Version: 1.1.1

var testCases = []struct {
description string
input int
expectError bool
expected int
}{
{
description: "zero steps for one",
input: 1,
expected: 0,
},
{
description: "divide if even",
input: 16,
expected: 4,
},
{
description: "even and odd steps",
input: 12,
expected: 9,
},
{
description: "Large number of even and odd steps",
input: 1000000,
expected: 152,
},
{
description: "zero is an error",
input: 0,
expectError: true,
},
{
description: "negative value is an error",
input: -15,
expectError: true,
},
}
42 changes: 0 additions & 42 deletions exercises/collatz-conjecture/collatz_conjecture_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,6 @@ import (
"testing"
)

var testCases = []struct {
description string
input int
expectError bool
expected int
}{
{
description: "zero steps for one",
input: 1,
expectError: false,
expected: 0,
},
{
description: "divide if even",
input: 16,
expectError: false,
expected: 4,
},
{
description: "even and old steps",
input: 12,
expectError: false,
expected: 9,
},
{
description: "large number of even and odd steps",
input: 1000000,
expectError: false,
expected: 152,
},
{
description: "zero is an error",
input: 0,
expectError: true,
},
{
description: "negative value is an error",
input: -15,
expectError: true,
},
}

func TestCollatzConjecture(t *testing.T) {
for _, testCase := range testCases {
steps, err := CollatzConjecture(testCase.input)
Expand Down