Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfect-numbers: create test case generator #952

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

leenipper
Copy link
Contributor

Add .meta/gen.go to generate cases_test.go.

Update test program to use generated test case array.
Put FAIL and PASS in test result output.
Keep TestGivesPositiveRequiredError redundant test on zero
since it verifies ErrOnlyPositive.

Update example solution to use int64 for input type
since -1 test case in canonical-data.json.

For #605.

Add .meta/gen.go to generate cases_test.go.

Update test program to use generated test case array.
Put FAIL and PASS in test result output.
Keep TestGivesPositiveRequiredError redundant test on zero
since it verifies ErrOnlyPositive.

Update example solution to use int64 for input type
since -1 test case in canonical-data.json.

For exercism#605.
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leenipper leenipper merged commit e33c5c2 into exercism:master Nov 13, 2017
@leenipper leenipper deleted the perfect-numbers-add-generator branch November 13, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants