isogram: add test generator #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
|
Sorry for the delay I've been AFK for a few days. Will catch up on these soon. |
|
@tleen No worries 😄 |
tleen
approved these changes
Nov 5, 2017
exercises/isogram/isogram_test.go
Outdated
| if IsIsogram(c.word) != c.expected { | ||
| t.Fatalf("FAIL: Word %q, expected %v, got %v", c.word, c.expected, !c.expected) | ||
| if IsIsogram(c.input) != c.expected { | ||
| t.Fatalf("FAIL: Word %q, expected %t, got %t", c.input, c.expected, !c.expected) |
There was a problem hiding this comment.
Do you think its worth adding the test case description here as an indicator for what went wrong?
There was a problem hiding this comment.
I think it's better, added.
ferhatelmas
force-pushed
the
isogram-generator
branch
from
3caf319 to
e5c8a35
Compare
tleen
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #605.