Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangram: Remove non-ASCII compatible test cases #803

Merged
merged 1 commit into from
Aug 15, 2017
Merged

pangram: Remove non-ASCII compatible test cases #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/pangram/example.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"strings"
)

const testVersion = 1
const testVersion = 2

func IsPangram(s string) bool {
lowerString := strings.ToLower(s)
Expand Down
2 changes: 1 addition & 1 deletion exercises/pangram/pangram.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package pangram

const testVersion = 1
const testVersion = 2

func IsPangram(string) bool
4 changes: 1 addition & 3 deletions exercises/pangram/pangram_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"testing"
)

const targetTestVersion = 1
const targetTestVersion = 2

type testCase struct {
input string
Expand All @@ -20,8 +20,6 @@ var testCases = []testCase{
{"the 1 quick brown fox jumps over the 2 lazy dogs", true, ""},
{"7h3 qu1ck brown fox jumps ov3r 7h3 lazy dog", false, "missing letters replaced by numbers"},
{"\"Five quacking Zephyrs jolt my wax bed.\"", true, ""},
{"Victor jagt zwölf Boxkämpfer quer über den großen Sylter Deich.", true, ""},
{"Широкая электрификация южных губерний даст мощный толчок подъёму сельского хозяйства.", false, "Panagram in alphabet other than ASCII"},
}

func TestTestVersion(t *testing.T) {
Expand Down