Phone number add generator #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate one test case array from the canonical-data.json named numberTests; for non-error cases, also include the fields necessary to run the AreaCode and Format tests. Update test program to use the numberTests array from cases_test.go. Remove redundant targetTestVersion tests in TestAreaCode and TestFormat. Update example solution to pass all the tests. Increment testVersion and targetTestVersion b/c of new test cases.
Update test program to output the test case description in the FAIL output to help indicate reason for failure.
robphoenix
approved these changes
May 5, 2017
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #605