Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lasagna_test.go #2779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update lasagna_test.go #2779

wants to merge 1 commit into from

Conversation

jhvhs
Copy link

@jhvhs jhvhs commented Apr 3, 2024

Fix a typo

Although, both variables hold the same value, and this typo does not cause tests to fail for the wrong reason, it doesn't feel right to use the wrong variable.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions bot closed this Apr 3, 2024
@andrerfcsantos
Copy link
Member

Hey @jhvhs

Reopening this as it still is relevant, sorry for taking so long to review this.

Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Let me know if you are still interested in working on this, otherwise I can just finish the PR for you.

@@ -19,7 +19,7 @@ func TestOvenTime(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := OvenTime; got != tt.expected {
t.Errorf("OvenTime(%d) = %d; want %d", tt.expected, got, tt.expected)
t.Errorf("OvenTime(%d) = %d; want %d", tt.time, got, tt.expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Errorf("OvenTime(%d) = %d; want %d", tt.time, got, tt.expected)
t.Errorf("OvenTime = %d; want %d", got, tt.expected)

Since OvenTime is not a function, It's probably more appropriate to just do this.

@andrerfcsantos andrerfcsantos added the x:size/small Small amount of work label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants