Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename concept exercises #1464

Merged
merged 26 commits into from
Jul 5, 2021
Merged

Rename concept exercises #1464

merged 26 commits into from
Jul 5, 2021

Conversation

angelikatyborska
Copy link
Member

@angelikatyborska angelikatyborska commented Jul 3, 2021

This PR renames concept exercises to have names based on stories, not on concepts.

I'm opening a draft PR to let you know I'm working on this.

I try to encapsulate each rename in a single commit for easier reviewing.

Renames

  • booleans -> annalyns-infiltration (name from C#)
  • comments -> weather-forecast
  • conditionals -> blackjack
  • constants -> savings-account
  • errors -> deep-thought
  • maps -> gross-store
  • methods -> elons-toys (name from C#)
  • numbers -> cars-assemble (name from C#)
  • structs -> need-for-speed (name from C#)
  • slices -> card-tricks
  • strings -> party-robot
  • strings-package -> logs-logs-logs (name from C#)
  • time -> booking-up-for-beauty (name from C#)
  • zero-values -> zero, zilch, nada

I can change again any name that you don't like 🙂.

I put the concepts in config.json in alphabetical order, and concept exercises in the rough order in which they will be unlocked.

This PRs also contains blurbs for all the concept exercises.

Some unexpected changes

  • blackjack (prev conditionals) claimed to teach booleans, but that concept is already taught by annalyns-infiltration (prev booleans). I made blackjack require booleans instead and slightly reordered its introduction.
  • Some exercises claimed to require the concept conditionals, which doesn't exist. I had to change that to either conditionals-if, conditionals-switch, or both.
  • Some exercises claimed to require the concept functions, which I suspect is now part of basics. Is that correct? I removed that requirement.

config.json Outdated Show resolved Hide resolved
{
"name": "Structs",
"slug": "structs",
"uuid": "5bd431cf-c30d-4f5c-a16d-c62e51720fbd"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated new uuids for everything I'm adding. Is that correct? I saw that there's some config.orig.json file around 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, new UUIDs are preferable and I don't think that will cause any issues with the website? I think we can try it and see, and revert to the ones in config.orig.json as needed. I think we can also remove that file now that you've migrated the exercises over?

Copy link
Contributor

@ekingery ekingery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for stepping in to help salvage the Go track for launch, @angelikatyborska! I added / resolved some comments and renamed a few packages, I hope that is OK/works.

config.json Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
{
"name": "Structs",
"slug": "structs",
"uuid": "5bd431cf-c30d-4f5c-a16d-c62e51720fbd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, new UUIDs are preferable and I don't think that will cause any issues with the website? I think we can try it and see, and revert to the ones in config.orig.json as needed. I think we can also remove that file now that you've migrated the exercises over?

exercises/concept/annalyns-infiltration/.meta/exemplar.go Outdated Show resolved Hide resolved
exercises/concept/deep-thought/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/need-for-speed/need_for_speed.go Outdated Show resolved Hide resolved
exercises/concept/need-for-speed/need_for_speed_test.go Outdated Show resolved Hide resolved
exercises/concept/savings-account/.meta/exemplar.go Outdated Show resolved Hide resolved
exercises/concept/savings-account/savings_account.go Outdated Show resolved Hide resolved
exercises/concept/savings-account/savings_account_test.go Outdated Show resolved Hide resolved
@angelikatyborska angelikatyborska marked this pull request as ready for review July 5, 2021 12:55
@angelikatyborska
Copy link
Member Author

I finished all the renaming. Configlet checks are failing due to empty concept authors.

There are a lot of failures in the "exercie tests" jobs but I'm not sure if they have anything to do with this PR...

Some observations:

  • some concept exercises have a go.mod file, while others don't. Is that expected?
  • the logs-logs-logs (previously strings-package) exercise has an introduction that doesn't sound specific to the strings package to me, but rather to strings in general (but there already is an introduction to strings in general in party-robot). Maybe it's a wrong impression because I don't know go?
  • the zero-values exercise doesn't have a story 🙊 hence its new name is just a bunch of synonyms for "zero" :D

Copy link
Contributor

@ekingery ekingery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. I think I suggested two typo fixes, and beyond that we're good to merge. Thanks again for your celebrity guest appearance on the Go track, @angelikatyborska!

There are a lot of failures in the "exercie tests" jobs but I'm not sure if they have anything to do with this PR...

Likely unrelated, and if not we can resolve them later when someone has time to work through all of the test failures.

Some observations:

  • some concept exercises have a go.mod file, while others don't. Is that expected?

I think ideally they all would use modules (and have a go.sum file), but it shouldn't prevent us from using an exercise in the meantime.

  • the logs-logs-logs (previously strings-package) exercise has an introduction that doesn't sound specific to the strings package to me, but rather to strings in general (but there already is an introduction to strings in general in party-robot). Maybe it's a wrong impression because I don't know go?

Yes, good observation. It's difficult to cleanly separate the related concepts / types in Go, so I think this is probably OK for now.

  • the zero-values exercise doesn't have a story speak_no_evil hence its new name is just a bunch of synonyms for "zero" :D
    0️⃣ 🥇

exercises/concept/cars-assemble/.docs/introduction.md Outdated Show resolved Hide resolved
exercises/concept/car-factory/.meta/design.md Outdated Show resolved Hide resolved
exercises/concept/cars-assemble/.meta/design.md Outdated Show resolved Hide resolved
@ekingery ekingery merged commit 92eb8bc into exercism:main Jul 5, 2021
@angelikatyborska angelikatyborska deleted the rename-concept-exercises branch July 5, 2021 20:18
@angelikatyborska
Copy link
Member Author

Let me see what I broke 😰
Screen Shot 2021-07-05 at 22 20 30

@angelikatyborska
Copy link
Member Author

angelikatyborska commented Jul 5, 2021

The cycle is between cars-assembly which teaches numbers and type-conversion, and requires conditionals-if, and blackjack which teaches conditionals-{if,switch} and requires numbers.

@ekingery
Copy link
Contributor

ekingery commented Jul 5, 2021

The cycle is between cars-assembly which teaches numbers and type-conversion and requires conditionals-if and blackjack which teaches conditionals-{if,switch} and requires numbers.

That was a quick find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants