-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename concept exercises #1464
Rename concept exercises #1464
Conversation
{ | ||
"name": "Structs", | ||
"slug": "structs", | ||
"uuid": "5bd431cf-c30d-4f5c-a16d-c62e51720fbd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generated new uuids for everything I'm adding. Is that correct? I saw that there's some config.orig.json
file around 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, new UUIDs are preferable and I don't think that will cause any issues with the website? I think we can try it and see, and revert to the ones in config.orig.json
as needed. I think we can also remove that file now that you've migrated the exercises over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for stepping in to help salvage the Go track for launch, @angelikatyborska! I added / resolved some comments and renamed a few packages, I hope that is OK/works.
{ | ||
"name": "Structs", | ||
"slug": "structs", | ||
"uuid": "5bd431cf-c30d-4f5c-a16d-c62e51720fbd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, new UUIDs are preferable and I don't think that will cause any issues with the website? I think we can try it and see, and revert to the ones in config.orig.json
as needed. I think we can also remove that file now that you've migrated the exercises over?
I finished all the renaming. Configlet checks are failing due to empty concept authors. There are a lot of failures in the "exercie tests" jobs but I'm not sure if they have anything to do with this PR... Some observations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. I think I suggested two typo fixes, and beyond that we're good to merge. Thanks again for your celebrity guest appearance on the Go track, @angelikatyborska!
There are a lot of failures in the "exercie tests" jobs but I'm not sure if they have anything to do with this PR...
Likely unrelated, and if not we can resolve them later when someone has time to work through all of the test failures.
Some observations:
- some concept exercises have a
go.mod
file, while others don't. Is that expected?
I think ideally they all would use modules (and have a go.sum
file), but it shouldn't prevent us from using an exercise in the meantime.
- the
logs-logs-logs
(previouslystrings-package
) exercise has an introduction that doesn't sound specific to thestrings
package to me, but rather tostrings
in general (but there already is an introduction to strings in general inparty-robot
). Maybe it's a wrong impression because I don't know go?
Yes, good observation. It's difficult to cleanly separate the related concepts / types in Go, so I think this is probably OK for now.
- the
zero-values
exercise doesn't have a story speak_no_evil hence its new name is just a bunch of synonyms for "zero" :D
0️⃣ 🥇
Co-authored-by: Eric Kingery <[email protected]>
Co-authored-by: Eric Kingery <[email protected]>
The cycle is between |
That was a quick find, thanks! |
This PR renames concept exercises to have names based on stories, not on concepts.
I'm opening a draft PR to let you know I'm working on this.
I try to encapsulate each rename in a single commit for easier reviewing.
Renames
I can change again any name that you don't like 🙂.
I put the concepts in
config.json
in alphabetical order, and concept exercises in the rough order in which they will be unlocked.This PRs also contains blurbs for all the concept exercises.
Some unexpected changes
blackjack
(prevconditionals
) claimed to teachbooleans
, but that concept is already taught byannalyns-infiltration
(prevbooleans
). I madeblackjack
requirebooleans
instead and slightly reordered its introduction.conditionals
, which doesn't exist. I had to change that to eitherconditionals-if
,conditionals-switch
, or both.functions
, which I suspect is now part ofbasics
. Is that correct? I removed that requirement.