Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

largest-series-product: ensure generator is up-to-date #633

Closed
robphoenix opened this issue Apr 18, 2017 · 0 comments
Closed

largest-series-product: ensure generator is up-to-date #633

robphoenix opened this issue Apr 18, 2017 · 0 comments

Comments

@robphoenix
Copy link
Contributor

Parent issue: #604

Because of recent changes to make all the canonical-data.json files conform to
a common scheme (exercism/problem-specifications#625), it might be
the case that our current generator no longer runs.

For this exercise we need to make sure the current generator runs, and if it
doesn't then we need to update it.

In addition, the three lines at the top of the file:

// Source: {{.Ori}}
{{if .Commit}}// Commit: {{.Commit}}
{{end}}

can simply be replaced with {{.Header}}, which has the effect of:

  • Deprecating the Ori field, which is confusingly named
  • Showing the x-common version in the test file
  • Reducing duplicate code
leenipper added a commit to leenipper/xgo that referenced this issue Apr 27, 2017
Resolves exercism#633

Use .Header in template.
Two test cases get dropped from canonical-data.json,
so bump testVersion/targetTestVersion in the test program
and example solution from 4 to 5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant