Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistency across exercise tests #470

Closed
robphoenix opened this issue Jan 30, 2017 · 17 comments
Closed

Ensure consistency across exercise tests #470

robphoenix opened this issue Jan 30, 2017 · 17 comments
Labels
good first issue

Comments

@robphoenix
Copy link
Contributor

robphoenix commented Jan 30, 2017 •
edited
Loading

#465 highlighted certain test file inconsistencies between the exercises.
These were:

  1. lack of testVersion/targetTestVersion for all exercises, initialised at 1, to be incremented upon significant changes
  2. separate TestTestVersion function, rather than as part of main test function
  3. placement of TestTestVersion function as the first test function
  4. TestTestVersion function using Fatalf rather than Errorf
@robphoenix
Copy link
Contributor Author

robphoenix commented Jan 30, 2017 •
edited by tleen
Loading

List of all exercises, to be checked individually for consistency and ticked off when meeting the above conditions.

  • accumulate
  • acronym
  • all-your-base
  • allergies
  • anagram
  • atbash-cipher
  • bank-account
  • beer-song
  • binary-search-tree
  • binary-search
  • binary
  • bob
  • bracket-push
  • circular-buffer
  • clock
  • connect
  • counter (deprecated)
  • crypto-square
  • custom-set
  • diamond
  • difference-of-squares
  • diffie-hellman
  • error-handling
  • etl
  • food-chain
  • gigasecond
  • grade-school
  • grains
  • hamming
  • hello-world
  • hexadecimal
  • house
  • isogram
  • kindergarten-garden
  • largest-series-product
  • leap
  • ledger
  • luhn
  • matrix
  • meetup
  • minesweeper
  • nth-prime
  • nucleotide-count
  • ocr-numbers
  • octal
  • paasio
  • palindrome-products
  • pangram
  • parallel-letter-frequency
  • pascals-triangle
  • perfect-numbers
  • phone-number
  • pig-latin
  • poker
  • pov
  • prime-factors
  • protein-translation
  • pythagorean-triplet
  • queen-attack
  • raindrops
  • react
  • rna-transcription
  • robot-name
  • robot-simulator
  • roman-numerals
  • saddle-points
  • say
  • scrabble-score
  • secret-handshake
  • series
  • sieve
  • simple-cipher
  • strain
  • sum-of-multiples
  • tournament
  • transpose
  • tree-building
  • triangle
  • trinary
  • twelve-days
  • variable-length-quantity
  • word-count
  • word-search
  • wordy

@tleen tleen mentioned this issue Jan 30, 2017
Closed
@robphoenix robphoenix mentioned this issue Jan 31, 2017
Merged
robphoenix pushed a commit that referenced this issue Jan 31, 2017
@tleen @robphoenix
added test versioning consistency to accumulate, see #470 (#472)
8484f4c 
* added test versioning consistency to accumulate, see #470

* removed comment about test versioning in accumulate example
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
wordy: add test versioning, see exercism#470
a678115
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
wordy: add test versioning, see exercism#470
b3f6a60
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
word-search: improve test consistency (exercism#470)
6a963c5
@tleen
Copy link
Member

tleen commented Feb 1, 2017 •
edited
Loading

acronym is already ok...wait no, needs fatalf

robphoenix added a commit that referenced this issue Feb 1, 2017
@robphoenix
Merge pull request #478 from tleen/master
d22b681 
changed test version check error to fatal in acronym, see #470
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
move TestTestVersion function (exercism#470)
065f834
@robphoenix robphoenix mentioned this issue Feb 1, 2017
Merged
robphoenix added a commit that referenced this issue Feb 1, 2017
@robphoenix
Merge pull request #475 from robphoenix/test-consistency/wordy
cda44ba 
wordy: add test versioning, see #470
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
word-search: extract TestTestVersion function (exercism#470)
7b3466b
robphoenix added a commit that referenced this issue Feb 1, 2017
@robphoenix
Merge pull request #476 from robphoenix/test-consistency/word-search
d488828 
word-search: extract TestTestVersion function (#470)
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 1, 2017
luhn: move TestTestVersion to be first test (exercism#470)
1d17636
@tleen tleen mentioned this issue Feb 1, 2017
Merged
robphoenix added a commit that referenced this issue Feb 1, 2017
@robphoenix
Merge pull request #480 from robphoenix/test-consistency/luhn
c48b12d 
luhn: move TestTestVersion to be first test (#470)
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 3, 2017
pangram: Errorf -> Fatalf in TestTestVersion
47f46ee 
see exercism#470
@robphoenix robphoenix mentioned this issue Feb 3, 2017
Merged
robphoenix added a commit that referenced this issue Feb 4, 2017
@robphoenix
Merge pull request #483 from tleen/allergies/test-consistency
9e06263 
allergies: extracted test version test as its own function, see #470
robphoenix added a commit that referenced this issue Feb 4, 2017
@robphoenix
Merge pull request #485 from tleen/atbash-cipher/test-consistency
be9c134 
atbash-cipher: added test versioning, see #470
robphoenix added a commit that referenced this issue Feb 4, 2017
@robphoenix
Merge pull request #484 from tleen/anagram/test-consistency
fa75bd6 
anagram: added test versioning, see #470
robphoenix added a commit that referenced this issue Feb 6, 2017
@robphoenix
Merge pull request #486 from tleen/bank-account/test-consistency
7f846c6 
bank-account: added test versioning, see #470
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 6, 2017
word-count: move version testing into own function
4924d05 
see exercism#470
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 6, 2017
word-count: move version testing into own function
1ac699d 
see exercism#470
@robphoenix robphoenix mentioned this issue Feb 6, 2017
Merged
@tleen tleen mentioned this issue Feb 6, 2017
Merged
robphoenix added a commit that referenced this issue Feb 6, 2017
@robphoenix
Merge pull request #490 from tleen/binary-search-tree/test-consistency
09aa923 
binary-search-tree: added test versioning, see #470
robphoenix pushed a commit to robphoenix/exercism-go that referenced this issue Feb 6, 2017
vlq: add test versioning (exercism#470)
1406239
tleen added a commit that referenced this issue Mar 15, 2017
@tleen
scrabble-score: Ensure test versioning consistency with other exercis…
f71ac77 
…es (#586)

* Isolated test version testing to its own function

See #470
tleen added a commit that referenced this issue Mar 15, 2017
@tleen
secret-handshake: Ensure test versioning consistency with other exerc…
f2f15ad 
…ises (#587)

* Isolated test version testing to its own function

See #470
tleen added a commit that referenced this issue Mar 15, 2017
@tleen
sieve: Add test versioning (#588)
a645a8d 
See #470
This was referenced Mar 15, 2017
Merged
Merged
Merged
Merged
Merged
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
simple-cipher: Add test versioning (#589)
fc685cf 
See #470
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
sum-of-multiples: Add test versioning (#590)
dc6b6ef 
See #470
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
tournament: Ensure test versioning consistency with other exercises (#…
1553399 
…591)

* Isolated test version test to its own function

See #470
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
transpose: Add test versioning (#592)
bc798a9 
See #470
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
tree-building: Ensure test versioning consistency with other exercises (
4801bf6 
#593)

* Moved TestTestVersion to top of tests
See #470
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
triangle: Ensure test versioning consistency with other exercises (#594)
d5ed657 
* Moved TestVersionTest to start of test functions
see #470
@tleen tleen mentioned this issue Mar 16, 2017
Merged
tleen added a commit that referenced this issue Mar 16, 2017
@tleen
trinary-test: Ensure test versioning consistency with other exercises (…
f276845 
…#595)

* Errorf -> Fatalf

See #470
@tleen tleen mentioned this issue Mar 17, 2017
Merged
tleen added a commit that referenced this issue Mar 17, 2017
@tleen
twelve-days: Ensure test versioning consistency with other exercises (#…
017ecba 
…596)

* Moved TestTestVersion to top of test functions
* Errorf -> Fatalf

See #470
@tleen
Copy link
Member

tleen commented Mar 17, 2017

I believe this is accomplished?

🍀 😄

@robphoenix
Copy link
Contributor Author

robphoenix commented Mar 17, 2017 •
edited
Loading

@tleen you're a test consistency powerhouse! 💪 Well done for finishing this off.

@tleen
Copy link
Member

tleen commented Mar 17, 2017

Good stuff. I'll close this one out. 👍

@tleen tleen closed this as completed Mar 17, 2017
@tleen tleen mentioned this issue Mar 23, 2017
Merged
@petertseng
Copy link
Member

Nice work doing this for all 80 of our exercises! (Plus the deprecated ones, I believe that makes it 85)

If y'all are thinking of other things to do, could consider ensuring that all exercises in x-common that have canonical-data.json have a test generator, and that the test generators still run (due to recent schema changes, some generators might require changes). This can help our track more easily keep up with changes to x-common (just rerun the generator, and we are done!).

No obligation to take this suggestion, since I don't consider myself to hold any special authority here; just whatever makes our lives as maintainers easier.

@tleen
Copy link
Member

tleen commented Mar 31, 2017

Sure. I'm sort of swamped at work till mid-April but if you make an issue for this we can slowly work our way through it like with the test versioning.

@robphoenix
Copy link
Contributor Author

I'd been thinking this same thing. I'll make a start on it in the coming weeks also.

@petertseng
Copy link
Member

OK. I can't start to make the issue for the next 4 hours. I will do it after that, unless one of you says you are before then.

@petertseng petertseng mentioned this issue Apr 12, 2017
Closed
@robphoenix robphoenix mentioned this issue Apr 18, 2017
Open
48 tasks
@tleen tleen mentioned this issue Apr 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kytrinyx @petertseng @tleen @robphoenix