Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run example solutions on CI #99

Merged
merged 4 commits into from
Nov 6, 2022
Merged

Run example solutions on CI #99

merged 4 commits into from
Nov 6, 2022

Conversation

lpil
Copy link
Member

@lpil lpil commented Nov 6, 2022

Closes #96

@lpil lpil requested review from SleeplessByte and a team November 6, 2022 14:46
dir=$(realpath "$1")
slug=$(basename "${dir}")
module=${slug//-/_}
implementation_file="${dir}/.meta/example.gleam"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, you may want to pull this from the config file, because it's commonplace to use example (or proof.ci) for practice exercises and exemplar for concept exercises.

Copy link
Member Author

@lpil lpil Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that but the other scripts I referenced worked this way, so I figured it would be easier to do this rather than remember how jq works 😁

We can improve this later when we get concepts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, most tracks hardcoded it too 😄, but some like JavaScript started using the config when provided for more flexibility.

@lpil lpil merged commit f93f718 into main Nov 6, 2022
@lpil lpil deleted the testing branch November 6, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run example solutions on CI
2 participants