Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test runner #2

Merged
merged 16 commits into from
Nov 15, 2022
Merged

Create test runner #2

merged 16 commits into from
Nov 15, 2022

Conversation

lpil
Copy link
Member

@lpil lpil commented Nov 11, 2022

Hello!

Thank you for making such a wonderful template repository. It was very easy to create a Gleam test runner using it as a base.

Closes exercism/gleam#28

@lpil lpil force-pushed the create branch 2 times, most recently from a0fc58a to 75372ba Compare November 11, 2022 14:27
@lpil lpil marked this pull request as ready for review November 11, 2022 15:02
@lpil lpil requested review from iHiD and a team November 11, 2022 15:03
bin/run.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing I did find is that running the tests seemed to be relatively slow, and I have a beefy machine. We'll need to see if there are timeouts once we have this deployed.

Thank you for making such a wonderful template repository. It was very easy to create a Gleam test runner using it as a base.

Thanks! This is lovely to hear.

Note that for the test runner to be deployed, @iHiD needs to merge exercism/terraform#82 and then run terraform (as well as giving proper access to the right secrets).

Copy link

@chouzar chouzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to do some tests but I'm likely missing something.

README.md Show resolved Hide resolved
@lpil
Copy link
Member Author

lpil commented Nov 15, 2022

LGTM! One thing I did find is that running the tests seemed to be relatively slow, and I have a beefy machine. We'll need to see if there are timeouts once we have this deployed.

@ErikSchierboom That's interesting- how long did they take to run for you? It takes 2 seconds to run an exercise for me on my laptop, though that is outside of docker.

@lpil
Copy link
Member Author

lpil commented Nov 15, 2022

I've attempted to improve performance by precompiling the deps. I could possibly optimise it further by using the JavaScript backend, but seeing as there's lots of tracks that compile a lot slower than Erlang (and a literal Erlang track!) that shouldn't be required. Perhaps there is some other problem?

@ErikSchierboom
Copy link
Member

@ErikSchierboom That's interesting- how long did they take to run for you? It takes 2 seconds to run an exercise for me on my laptop, though that is outside of docker.

I found they took about 8-9 seconds, and that was using Docker. We've occasionally had tracks that were very slow in our Docker environment. But let's wait and see what things look like on our production servers.

@lpil
Copy link
Member Author

lpil commented Nov 15, 2022

OK, thank you!

@lpil lpil merged commit ca61a40 into main Nov 15, 2022
@lpil lpil deleted the create branch November 15, 2022 12:38
This was referenced Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Test Runner
5 participants