-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update org-wide-files #127
Conversation
Is this change because of the rate limits that we were hitting on GitHub Actions? If so, how does this change affect the rate limits, and when do the repos get the PRs for the changes? |
Not directly, no. This change is just there to prevent the org-wide-files PR from being created in the first place, as the files in this repo were outdated when compared to the ones in the org-wide-files repo. |
LICENSE
Outdated
@@ -1,6 +1,6 @@ | |||
MIT License | |||
|
|||
Copyright (c) 2021 Exercism | |||
Copyright (c) 2022 Exercism |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: The request-new-language-track
repo is maybe the only one where it makes sense to always use the current year :)
(We're tracking in exercism/org-wide-files#153).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it deliberate that you've changed it in this repo to 2022, but it's still 2021 in org-wide-files
?
Does this PR mean that a new track will instantly get a PR to update the LICENSE year to 2021?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably stop the license.md file from being synced I think. But for now, I've reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Reversing approval due to #127 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check:
$ git rev-parse HEAD
14689c452054a8e4a8fda5eeab760f8b53db6691
$ diff -s .github/workflows/configlet.yml ../org-wide-files/tracks-files/.github/workflows/configlet.yml
Files .github/workflows/configlet.yml and ../org-wide-files/tracks-files/.github/workflows/configlet.yml are identical
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
Having updated these files, new repos won't immediately get a pull request to update these files.