Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org-wide-files #127

Merged
merged 4 commits into from
May 5, 2022
Merged

Update org-wide-files #127

merged 4 commits into from
May 5, 2022

Conversation

ErikSchierboom
Copy link
Member

  • ci: update configlet workflow
  • ci: remove trailing whitespace from labels.yml
  • Update license to 2022

Having updated these files, new repos won't immediately get a pull request to update these files.

@kytrinyx
Copy link
Member

kytrinyx commented May 5, 2022

Is this change because of the rate limits that we were hitting on GitHub Actions? If so, how does this change affect the rate limits, and when do the repos get the PRs for the changes?

@ErikSchierboom
Copy link
Member Author

Is this change because of the rate limits that we were hitting on GitHub Actions?

Not directly, no. This change is just there to prevent the org-wide-files PR from being created in the first place, as the files in this repo were outdated when compared to the ones in the org-wide-files repo.

LICENSE Outdated
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2021 Exercism
Copyright (c) 2022 Exercism
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: The request-new-language-track repo is maybe the only one where it makes sense to always use the current year :)

(We're tracking in exercism/org-wide-files#153).

Copy link
Member

@ee7 ee7 May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it deliberate that you've changed it in this repo to 2022, but it's still 2021 in org-wide-files?

Does this PR mean that a new track will instantly get a PR to update the LICENSE year to 2021?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably stop the license.md file from being synced I think. But for now, I've reverted.

Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Reversing approval due to #127 (comment))

LICENSE Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom requested a review from ee7 May 5, 2022 10:54
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check:

$ git rev-parse HEAD
14689c452054a8e4a8fda5eeab760f8b53db6691
$ diff -s .github/workflows/configlet.yml ../org-wide-files/tracks-files/.github/workflows/configlet.yml
Files .github/workflows/configlet.yml and ../org-wide-files/tracks-files/.github/workflows/configlet.yml are identical

@ErikSchierboom
Copy link
Member Author

I did check

Thanks!

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@ErikSchierboom ErikSchierboom merged commit 89d2730 into main May 5, 2022
@ErikSchierboom ErikSchierboom deleted the update-org-wide-files branch May 5, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants