Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pop-count exercise #41

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add pop-count exercise #41

merged 1 commit into from
Jan 31, 2024

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Jan 24, 2024

No description provided.

@pfertyk pfertyk force-pushed the add-pop-count-exercise branch 3 times, most recently from 12c4228 to a3fdefd Compare January 24, 2024 19:25
@pfertyk pfertyk marked this pull request as ready for review January 24, 2024 19:27
@pfertyk
Copy link
Contributor Author

pfertyk commented Jan 24, 2024

@BNAndras the example solution uses a built-in method to convert a number to binary. Please let me know if I should instead implement the conversion step-by-step.

@BNAndras
Copy link
Member

Should be fine. The example just needs to prove the exercise can be solved.

@@ -0,0 +1,17 @@
{
"authors": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GitHub username

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep forgetting about this, thanks :D

@pfertyk pfertyk force-pushed the add-pop-count-exercise branch from a3fdefd to fd8725b Compare January 30, 2024 20:37
@BNAndras
Copy link
Member

Looks good. I'd rebase the PR to resolve the merge conflict

@pfertyk pfertyk force-pushed the add-pop-count-exercise branch from fd8725b to d40ee78 Compare January 31, 2024 18:17
@pfertyk pfertyk merged commit b3a66f0 into main Jan 31, 2024
2 checks passed
@pfertyk pfertyk deleted the add-pop-count-exercise branch January 31, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants