Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to Luhn tests #129

Closed
IanWhitney opened this issue Jan 11, 2017 · 3 comments
Closed

Changes to Luhn tests #129

IanWhitney opened this issue Jan 11, 2017 · 3 comments
Labels
good first patch

Comments

@IanWhitney
Copy link

We recently rewrote the test suite for the Luhn exercise. Since this track implements Luhn, please take a look at the new canonical_data.json file and see if your track should update its implementation or tests.

Details on the test changes and the motivation can be found in the PR.

Tracking of these changes is being done at the tracking issue.
@stale stale bot added the wontfix label Apr 29, 2017
@stale
Copy link

stale bot commented Apr 29, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@NobbZ NobbZ removed the wontfix label May 1, 2017
sjwarner-bp added a commit to sjwarner/erlang that referenced this issue Oct 2, 2017
@sjwarner-bp
Luhn: update tests to canonical data as in exercism#129
b58da7f 
As described in exercism#129, the canonical data for luhn tests was changed. These changes are now reflected in the erlang tests.
@sjwarner-bp sjwarner-bp mentioned this issue Oct 2, 2017
Closed
@sjwarner-bp
Copy link
Contributor

I have just updated the test file in this exercise to reflect the canonical data. I hope this is all ok!

sjwarner-bp pushed a commit to sjwarner/erlang that referenced this issue Oct 2, 2017
@sjwarner
Luhn: update tests to canonical data as in exercism#129
d53d79c
@sjwarner-bp sjwarner-bp mentioned this issue Oct 2, 2017
Merged
@sjwarner-bp
Copy link
Contributor

This new PR has an updated example.erl which actually passes all tests now. Hopefully this will be alright, then this issue may be closed.

NobbZ added a commit that referenced this issue Oct 5, 2017
@NobbZ
Merge pull request #184 from sjwarner-bp/master
d22ce56 
Luhn: update tests to canonical data as in #129
@NobbZ NobbZ closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanWhitney @NobbZ @sjwarner-bp