Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync docs, metadata and tests #724

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Sync docs, metadata and tests #724

merged 2 commits into from
Dec 10, 2024

Conversation

jiegillet
Copy link
Contributor

This PR syncs the docs, metadata, and adds two new tests (one is a re-implementation).

@@ -127,8 +127,8 @@ tests =
test "on multiple line questions" <|
\() ->
Expect.equal
"Whatever."
(Bob.hey "\nDoes this cryogenic chamber make me look fat?\nno")
"Sure."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the instructions would have to change too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, now it ends with a question mark, so the expected answer is different, as per the instructions.
I'm not sure what motivated this particular change, you'd have to check on the problem-specs repo.

@jiegillet jiegillet merged commit 1c2c1a6 into main Dec 10, 2024
8 checks passed
@jiegillet jiegillet deleted the jie-sync branch December 10, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants