Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new practice exercise sieve #665

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Add new practice exercise sieve #665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9af88
Add new practice exercise `sieve`
jiegillet Mar 9, 2024
77c9125
apply analyzer comment
jiegillet Mar 9, 2024
63ac999
fix config name
jiegillet Mar 9, 2024
4f234e2
Update exercises/practice/sieve/.meta/src/Sieve.example.elm
jiegillet Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/generate_practice_exercise.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ echo "Fetching latest version of configlet..."
echo "Adding instructions and configuration files..."
UUID=$(bin/configlet uuid)
jq --arg slug "$SLUG" --arg uuid "$UUID" \
'.exercises.practice += [{slug: $slug, name: $slug, uuid: $uuid, practices: [], prerequisites: [], difficulty: 5}]' \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to avoid a casing type problem with the title of the exercise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, it's too easy to miss when the name is prefilled, it happened a lot that people didn't change it (me included). At least with a big TODO you can't miss it (hopefully).

'.exercises.practice += [{slug: $slug, name: "TODO", uuid: $uuid, practices: [], prerequisites: [], difficulty: 5}]' \
config.json > config.json.tmp
mv config.json.tmp config.json

Expand Down
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@
},
{
"slug": "sieve",
"name": "sieve",
"name": "Sieve",
"uuid": "60804d7f-8eb3-46e0-8337-45b7426456b0",
"practices": [
"array"
Expand Down